Skip to content

feat: add stage to animation targets#513

Merged
MakinoharaShoko merged 1 commit intoOpenWebGAL:devfrom
HardyNLee:feat/animation-target
Nov 25, 2025
Merged

feat: add stage to animation targets#513
MakinoharaShoko merged 1 commit intoOpenWebGAL:devfrom
HardyNLee:feat/animation-target

Conversation

@HardyNLee
Copy link
Contributor

@HardyNLee HardyNLee commented Nov 21, 2025

介绍

为 setTransform setAnimation 图形组件的目标新增 "舞台画面" (stage-main)

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 21, 2025

Summary of Changes

Hello @HardyNLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the graphical editor by expanding the available targets for animations and transformations. It specifically introduces a "stage-main" option, allowing users to apply effects directly to the main stage area. This improvement provides greater flexibility and control over graphical component manipulation within the editor, supported by updated type definitions and localization strings.

Highlights

  • New Animation/Transform Target: Introduced "stage-main" as a valid preset target for setAnimation and setTransform graphical components, enabling effects to be applied directly to the main stage area.
  • Type Definition Update: Modified the PresetTarget type in both SetAnimation.tsx and SetTransform.tsx to explicitly include the new "stage-main" option, ensuring type safety and proper recognition of the new target.
  • Localization Support: Added the translation for "舞台画面" (Stage) to the English, Japanese, and Simplified Chinese localization files, ensuring the new target is correctly displayed across different language settings in the UI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 为 setTransform 和 setAnimation 组件添加了 “舞台画面” (stage-main) 作为新的目标选项，功能实现正确。

我注意到 PresetTarget 类型和 presetTargets 的定义在 SetAnimation.tsx、SetTransform.tsx 和 SetTransition.tsx 文件中存在重复。为了提高代码的可维护性，我建议将这部分重复的逻辑提取到一个共享文件中。

具体细节请查看我的评论。

@MakinoharaShoko MakinoharaShoko merged commit adecf87 into OpenWebGAL:dev Nov 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MakinoharaShoko MakinoharaShoko MakinoharaShoko approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HardyNLee @MakinoharaShoko